🚧 stop_and_save_print_to_ram should not overwrite valid partial backup
#4410
Conversation
|
All values in bytes. Δ Delta to base
|
gudnimg
changed the title
stop_and_save_print_to_ram should not overwrite valid partial backupstop_and_save_print_to_ram should not overwrite valid partial backup
gudnimg
force-pushed
the
cleanup-stop-save-print
branch
from
9d37ea4 to
ea3985f
Compare
|
Rebased to sync with MK3 branch (105 commits) |
gudnimg
force-pushed
the
cleanup-stop-save-print
branch
from
ea3985f to
a53fd06
Compare
| memcpy(saved_pos, current_position, sizeof(saved_pos)); | ||
| if (!isPartialBackupAvailable) { | ||
| refresh_print_state_in_ram(); | ||
| } |
There was a problem hiding this comment.
A problem I see here with this approach, is that now set_temp_error saves current_position before planner_abort_hard() is called, so current_position is not correct during a thermal error.
There was a problem hiding this comment.
@gudnimg Is this solved?
There was a problem hiding this comment.
No I havent had a good opportunity to look into this. I was too sick to do any productive things previous weekend
I will hopefully look at this again soon (and other PRs)
There was a problem hiding this comment.
@gudnimg is this solved?
There was a problem hiding this comment.
No the PR needs to be reworked to address this. I think we should postpone this after 3.14
Thermal errors need to take a backup of the target temperatures. When the print is then later paused, stop_and_save_print_to_ram should not overwrite the partial backup if it is still valid. Change in memory: Flash: -150 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
cleanup-stop-save-print
branch
from
a53fd06 to
673f0f8
Compare
|
Synced PR with latest MK3 branch (~126 commits) |
gudnimg
changed the title
stop_and_save_print_to_ram should not overwrite valid partial backupstop_and_save_print_to_ram should not overwrite valid partial backup
|
@gudnimg Is it still in progress or can that be reviewed? |
@3d-gussner This pull request needs more work, the comment from @wavexx is still valid and I haven't looked more into this. Closing PR for now since I'm unlikely to finish it soon. |
Thermal errors need to take a backup of the target temperatures before disabling the heaters. When the print is then later paused,
stop_and_save_print_to_ramshould use the partial backup if it is still valid (isPartialBackupAvailable=true). Afterstop_and_save_print_to_ramis done running and we have a 'full' backup,isPartialBackupAvailableis cleared in favor ofsaved_printingChange in memory:
Flash: -156 bytes
SRAM: 0 bytes